PHPLIB-1123: Use array_is_list
#1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Jun 7, 2023
src/Operation/CreateCollection.php
Outdated
| @@ -241,18 +242,14 @@ public function __construct(string $databaseName, string $collectionName, array | |||
| } | |||
|
|
|||
| if (isset($options['pipeline'])) { | |||
| $expectedIndex = 0; | |||
| if (! array_is_list($options['pipeline'])) { | |||
There was a problem hiding this comment.
It looks like psalm is missing that $options['pipeline'] is an array by this point. This might require a local variable assignment and @var annotation to overcome.
Alternatively, this might overlap with #1078 for PHPLIB-881.
There was a problem hiding this comment.
phpcs dictate me to use assert. This will be reverted by #1078.
There was a problem hiding this comment.
Strange that this was required given we throw earlier for:
if (isset($options['pipeline']) && ! is_array($options['pipeline']))Glad we'll be able to revert this, though.
5 tasks
jmikola
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPLIB-1123
Use the new function from PHP 8.1 to simplify code and optimise performances.
This PR will conflict with #1078